Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: Use gofumpt instead of gofmt to format Go #3096

Merged
merged 3 commits into from
Jul 10, 2020
Merged

go: Use gofumpt instead of gofmt to format Go #3096

merged 3 commits into from
Jul 10, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Jul 10, 2020

Fixes #3095

@kostko kostko force-pushed the kostko/feature/gofumpt branch 2 times, most recently from 962b754 to fab683c Compare July 10, 2020 08:50
@kostko kostko force-pushed the kostko/feature/gofumpt branch from fab683c to 533c4d8 Compare July 10, 2020 09:14
@kostko kostko force-pushed the kostko/feature/gofumpt branch from 533c4d8 to ffc1f7e Compare July 10, 2020 12:00
@kostko kostko marked this pull request as ready for review July 10, 2020 12:38
@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #3096 into master will increase coverage by 0.02%.
The diff coverage is 72.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3096      +/-   ##
==========================================
+ Coverage   68.29%   68.31%   +0.02%     
==========================================
  Files         372      372              
  Lines       36833    36823      -10     
==========================================
+ Hits        25155    25156       +1     
+ Misses       8432     8421      -11     
  Partials     3246     3246
Impacted Files Coverage Δ
go/common/crypto/signature/signature.go 56.94% <ø> (ø)
...ommon/crypto/signature/signers/file/file_signer.go 57.47% <ø> (ø)
go/common/crypto/tls/cert.go 63.41% <0.00%> (ø)
go/common/entity/entity.go 65.16% <ø> (ø)
go/common/grpc/auth/auth.go 100.00% <ø> (ø)
go/common/grpc/errors.go 92.30% <ø> (-0.20%) ⬇️
go/common/grpc/proxy/proxy.go 67.82% <ø> (ø)
go/common/grpc/wrapper.go 80.23% <ø> (ø)
go/common/ledger/ledger.go 0.00% <ø> (ø)
go/common/tracing/tracing.go 50.00% <0.00%> (ø)
... and 107 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d52975a...ffc1f7e. Read the comment docs.

Yawning
Yawning approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@Yawning Yawning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is gonna cause conflicts with my branch isn't it. :(

@kostko kostko merged commit c56a606 into master Jul 10, 2020
@kostko kostko deleted the kostko/feature/gofumpt branch July 10, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yawning Yawning Yawning approved these changes

@ptrus ptrus ptrus approved these changes

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use gofumpt for stricter formatting
3 participants
@kostko @Yawning @ptrus